]> Cypherpunks repositories - gostls13.git/commitdiff
runtime: skip TestGdbCoreSignalBacktrace on arches other than 386/amd64
authorMichael Pratt <mpratt@google.com>
Mon, 27 Mar 2023 19:20:58 +0000 (19:20 +0000)
committerGopher Robot <gobot@golang.org>
Mon, 27 Mar 2023 19:33:06 +0000 (19:33 +0000)
For #25218.

Change-Id: I4024a2064e0f56755fe40eb7489ba28eb4358c60
Reviewed-on: https://go-review.googlesource.com/c/go/+/479518
Run-TryBot: Michael Pratt <mpratt@google.com>
Reviewed-by: Cherry Mui <cherryyz@google.com>
Auto-Submit: Michael Pratt <mpratt@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>

src/runtime/runtime-gdb_unix_test.go

index a276fdbe8f43d770e0bd166d213a26d796b03bd4..f9cc64803e8a91e5a0e9e0e9d21bbfe287669dc9 100644 (file)
@@ -70,6 +70,11 @@ func TestGdbCoreSignalBacktrace(t *testing.T) {
                // to know how to enable/find core files on each OS.
                t.Skip("Test only supported on Linux")
        }
+       if runtime.GOARCH != "386" && runtime.GOARCH != "amd64" {
+               // TODO(go.dev/issue/25218): Other architectures use sigreturn
+               // via VDSO, which we somehow don't handle correctly.
+               t.Skip("Backtrace through signal handler only works on 386 and amd64")
+       }
 
        checkGdbEnvironment(t)
        t.Parallel()