]> Cypherpunks repositories - gostls13.git/commitdiff
runtime: disable async preemption on darwin/arm(64) for now
authorCherry Zhang <cherryyz@google.com>
Thu, 7 Nov 2019 22:02:56 +0000 (17:02 -0500)
committerCherry Zhang <cherryyz@google.com>
Thu, 7 Nov 2019 22:17:54 +0000 (22:17 +0000)
Enabling async preemption on darwin/arm and darwin/arm64 causes
the builder to fail, e.g.
https://build.golang.org/log/03f727b8f91b0c75bf54ff508d7d2f00b5cad4bf

Due to the limited resource, I haven't been able to get access on
those devices to debug. Disable async preemption for now.

Updates #35439.

Change-Id: I5a31ad6962c2bae8e6e9b8303c494610a8a4e50a
Reviewed-on: https://go-review.googlesource.com/c/go/+/205842
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
src/runtime/signal_arm.go
src/runtime/signal_arm64.go

index ff952b8b60c22cc25ebf2af7d750203f4a707aea..d11023a0c3007014f87e8b6855e4bdaea18c437c 100644 (file)
@@ -63,7 +63,9 @@ func (c *sigctxt) preparePanic(sig uint32, gp *g) {
        c.set_pc(uint32(funcPC(sigpanic)))
 }
 
-const pushCallSupported = true
+// TODO(issue 35439): enabling async preemption causes failures on darwin/arm.
+// Disable for now.
+const pushCallSupported = GOOS != "darwin"
 
 func (c *sigctxt) pushCall(targetPC uintptr) {
        // Push the LR to stack, as we'll clobber it in order to
index db2ab2720b769440d10d43c6d0fc96a0e0a8302c..fb09aff6f968bda3a71bd33e18442a3da74bb6f0 100644 (file)
@@ -79,7 +79,9 @@ func (c *sigctxt) preparePanic(sig uint32, gp *g) {
        c.set_pc(uint64(funcPC(sigpanic)))
 }
 
-const pushCallSupported = true
+// TODO(issue 35439): enabling async preemption causes failures on darwin/arm64.
+// Disable for now.
+const pushCallSupported = GOOS != "darwin"
 
 func (c *sigctxt) pushCall(targetPC uintptr) {
        // Push the LR to stack, as we'll clobber it in order to