]> Cypherpunks repositories - gostls13.git/commitdiff
runtime: skip TestNoShrinkStackWhileParking on netbsd/arm64
authorBryan C. Mills <bcmills@google.com>
Fri, 5 Nov 2021 14:11:11 +0000 (10:11 -0400)
committerBryan C. Mills <bcmills@google.com>
Fri, 5 Nov 2021 18:20:07 +0000 (18:20 +0000)
This test appears to deadlock frequently on the only netbsd-arm64
builder we have (netbsd-arm64-bsiegert). Skip the test to provide
more useful test coverage for other failures.

For #49382

Change-Id: I3be32f58ce1e396f7c69163e70cf58f779f57ac6
Reviewed-on: https://go-review.googlesource.com/c/go/+/361615
Trust: Bryan C. Mills <bcmills@google.com>
Trust: Benny Siegert <bsiegert@gmail.com>
Run-TryBot: Bryan C. Mills <bcmills@google.com>
Reviewed-by: Benny Siegert <bsiegert@gmail.com>
src/runtime/chan_test.go

index c9ce3ac643184f99a6776aa2b81971b9ddcf992d..355267c5e3a7332792510416f46f1b61eaa690d1 100644 (file)
@@ -624,6 +624,10 @@ func TestShrinkStackDuringBlockedSend(t *testing.T) {
 }
 
 func TestNoShrinkStackWhileParking(t *testing.T) {
+       if runtime.GOOS == "netbsd" && runtime.GOARCH == "arm64" {
+               testenv.SkipFlaky(t, 49382)
+       }
+
        // The goal of this test is to trigger a "racy sudog adjustment"
        // throw. Basically, there's a window between when a goroutine
        // becomes available for preemption for stack scanning (and thus,