cmd/go: require -buildmode=c-shared to take one main package

The current behavior is to filter out the non-main packages silently,
which is confusing if there are only non-main packages.
Instead, report an error unless it's used with a single main package.

To be clear, I don't really know what I'm doing.
It might be that multiple main packages are allowed, or even
that we do want the filtering, but all.bash passes with this change,
so I am taking that as a sign that we don't need that extra flexibility.

Fixes #15082.

Change-Id: I984d0f444a01c0ee0c3cd6646a75527ea99a9ebe
Reviewed-on: https://go-review.googlesource.com/46421
Run-TryBot: Russ Cox <rsc@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Ian Lance Taylor <iant@golang.org>

diff --git a/src/cmd/go/internal/work/build.go b/src/cmd/go/internal/work/build.go
index 20f3952d4a9de1b258795466c5219425f6d1ca53..a7949b6ff35a547623d443c7ecdac4185b2fa040 100644 (file)
--- a/src/cmd/go/internal/work/build.go
+++ b/src/cmd/go/internal/work/build.go
@@ -288,7 +288,7 @@ func BuildModeInit() {
                cfg.ExeSuffix = ".a"
                ldBuildmode = "c-archive"
        case "c-shared":
-               pkgsFilter = pkgsMain
+               pkgsFilter = oneMainPkg
                if gccgo {
                        codegenArg = "-fPIC"
                } else {