]> Cypherpunks repositories - gostls13.git/commitdiff
image/jpeg, image/png: replace Fatal with Error in tests
authorHiro <laciferin@gmail.com>
Tue, 1 Aug 2023 07:25:46 +0000 (07:25 +0000)
committerGopher Robot <gobot@golang.org>
Thu, 3 Aug 2023 15:56:27 +0000 (15:56 +0000)
Replaced t.Fatalf with t.Errorf for non-critical errors to footprint more failing test cases for better analysis of the error.

Change-Id: I6f51d21e37a4ddb95d239d8afed2154f3ef52d31
GitHub-Last-Rev: d56aa49bced80c80f1177ae4b9ce038265ead551
GitHub-Pull-Request: golang/go#60524
Reviewed-on: https://go-review.googlesource.com/c/go/+/499336
Run-TryBot: Ian Lance Taylor <iant@golang.org>
TryBot-Result: Gopher Robot <gobot@golang.org>
Auto-Submit: Ian Lance Taylor <iant@google.com>
Run-TryBot: Ian Lance Taylor <iant@google.com>
Reviewed-by: Ian Lance Taylor <iant@google.com>
Reviewed-by: David Chase <drchase@google.com>
src/image/jpeg/fuzz_test.go
src/image/png/fuzz_test.go

index bd534a921d7ce0078915cd16657dc775b6ac948d..91a991440149df612c9d83db3dcba5865a0c2cc4 100644 (file)
@@ -49,16 +49,18 @@ func FuzzDecode(f *testing.F) {
                        var w bytes.Buffer
                        err := Encode(&w, img, &Options{Quality: q})
                        if err != nil {
-                               t.Fatalf("failed to encode valid image: %s", err)
+                               t.Errorf("failed to encode valid image: %s", err)
+                               continue
                        }
                        img1, err := Decode(&w)
                        if err != nil {
-                               t.Fatalf("failed to decode roundtripped image: %s", err)
+                               t.Errorf("failed to decode roundtripped image: %s", err)
+                               continue
                        }
                        got := img1.Bounds()
                        want := img.Bounds()
                        if !got.Eq(want) {
-                               t.Fatalf("roundtripped image bounds have changed, got: %s, want: %s", got, want)
+                               t.Errorf("roundtripped image bounds have changed, got: %s, want: %s", got, want)
                        }
                }
        })
index 4b639459e71598fbf8a1dfeee642330c7fbe8567..ea4bf4ef4af8c2c4dd2cd16109023657fb606d83 100644 (file)
@@ -56,16 +56,18 @@ func FuzzDecode(f *testing.F) {
                        e := &Encoder{CompressionLevel: l}
                        err = e.Encode(&w, img)
                        if err != nil {
-                               t.Fatalf("failed to encode valid image: %s", err)
+                               t.Errorf("failed to encode valid image: %s", err)
+                               continue
                        }
                        img1, err := Decode(&w)
                        if err != nil {
-                               t.Fatalf("failed to decode roundtripped image: %s", err)
+                               t.Errorf("failed to decode roundtripped image: %s", err)
+                               continue
                        }
                        got := img1.Bounds()
                        want := img.Bounds()
                        if !got.Eq(want) {
-                               t.Fatalf("roundtripped image bounds have changed, got: %s, want: %s", got, want)
+                               t.Errorf("roundtripped image bounds have changed, got: %s, want: %s", got, want)
                        }
                }
        })