]> Cypherpunks repositories - gostls13.git/commitdiff
cmd/internal/link: disable selected DWARF tests on Solaris
authorThan McIntosh <thanm@google.com>
Mon, 18 Dec 2017 18:58:41 +0000 (13:58 -0500)
committerThan McIntosh <thanm@google.com>
Mon, 18 Dec 2017 19:13:33 +0000 (19:13 +0000)
Disable the three linker DWARF tests that invoke the compiler in
non-debug mode on Solaris, since this seems to trigger a split stack
overflow. These can be turned back on once the issue in question is
resolved.

Updates #23168.

Change-Id: I5be1b098e33e8bad3bc234a0964eab1dee7e7954
Reviewed-on: https://go-review.googlesource.com/84655
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
Run-TryBot: Than McIntosh <thanm@google.com>

src/cmd/link/internal/ld/dwarf_test.go

index 202ab8fcfcadb4ff8e38a657b641c5832b1e7bab..391601acaf23ff0c7b3bd0e7ce3aec6565ef44c8 100644 (file)
@@ -531,6 +531,9 @@ func TestInlinedRoutineRecords(t *testing.T) {
        if runtime.GOOS == "plan9" {
                t.Skip("skipping on plan9; no DWARF symbol table in executables")
        }
+       if runtime.GOOS == "solaris" {
+               t.Skip("skipping on solaris, pending resolution of issue #23168")
+       }
 
        const prog = `
 package main
@@ -748,6 +751,9 @@ func TestAbstractOriginSanity(t *testing.T) {
        if runtime.GOOS == "plan9" {
                t.Skip("skipping on plan9; no DWARF symbol table in executables")
        }
+       if runtime.GOOS == "solaris" {
+               t.Skip("skipping on solaris, pending resolution of issue #23168")
+       }
 
        abstractOriginSanity(t, OptInl4)
 }
@@ -758,6 +764,9 @@ func TestAbstractOriginSanityWithLocationLists(t *testing.T) {
        if runtime.GOOS == "plan9" {
                t.Skip("skipping on plan9; no DWARF symbol table in executables")
        }
+       if runtime.GOOS == "solaris" {
+               t.Skip("skipping on solaris, pending resolution of issue #23168")
+       }
        if runtime.GOARCH != "amd64" && runtime.GOARCH != "x86" {
                t.Skip("skipping on not-amd64 not-x86; location lists not supported")
        }