[dev.link] all: reenable cgo internal linking tests

Cgo internal linking was disabled when switching to new object
files. Reeanble the tests, as they get supported.

Change-Id: I11d2ac8785cce73f3a42f6935c10d9f067bc90a4
Reviewed-on: https://go-review.googlesource.com/c/go/+/204520
Reviewed-by: Than McIntosh <thanm@google.com>

diff --git a/src/cmd/dist/test.go b/src/cmd/dist/test.go
index eeddd9474c7c790ebb43d4a56776c14ba7f0e06a..cc54554a1daabed84b6485cf241cd32d335dbf9e 100644 (file)
--- a/src/cmd/dist/test.go
+++ b/src/cmd/dist/test.go
@@ -904,9 +904,6 @@ func (t *tester) extLink() bool {
 }
 
 func (t *tester) internalLink() bool {
-       if true { // appease vet...
-               return false // TODO: newobj
-       }
        if gohostos == "dragonfly" {
                // linkmode=internal fails on dragonfly since errno is a TLS relocation.
                return false

diff --git a/src/cmd/nm/nm_cgo_test.go b/src/cmd/nm/nm_cgo_test.go
index dde24a0b728bf682fbd6e54e0abd3ce59a51cc65..9a257e0ed2eced69d18e9e6385aafe3d6286528f 100644 (file)
--- a/src/cmd/nm/nm_cgo_test.go
+++ b/src/cmd/nm/nm_cgo_test.go
@@ -37,7 +37,7 @@ func canInternalLink() bool {
 }
 
 func TestInternalLinkerCgoExec(t *testing.T) {
-       if !canInternalLink() || true { // TODO: newobj
+       if !canInternalLink() {
                t.Skip("skipping; internal linking is not supported")
        }
        testGoExec(t, true, false)

diff --git a/src/debug/pe/file_cgo_test.go b/src/debug/pe/file_cgo_test.go
index e89894953be93cf4054803e111822c9414dad2f9..739671d73f155d95d3e42c7bfee9e72d50f414ff 100644 (file)
--- a/src/debug/pe/file_cgo_test.go
+++ b/src/debug/pe/file_cgo_test.go
@@ -23,7 +23,6 @@ func TestDefaultLinkerDWARF(t *testing.T) {
 }
 
 func TestInternalLinkerDWARF(t *testing.T) {
-       t.Skip("TODO: newobj")
        testCgoDWARF(t, linkCgoInternal)
 }