]> Cypherpunks repositories - gostls13.git/commitdiff
os: skip Lchown test on Android if symlink doesn't work
authorHana Kim <hyangah@gmail.com>
Mon, 9 May 2016 19:14:07 +0000 (15:14 -0400)
committerHyang-Ah Hana Kim <hyangah@gmail.com>
Mon, 9 May 2016 20:02:34 +0000 (20:02 +0000)
After upgrading builder device (android/arm) to android 5.0.2,
the test started failing. Running 'ln -s' from shell fails with
permission error.

Change-Id: I5b9e312806d58532b41ea3560ff079dabbc6424e
Reviewed-on: https://go-review.googlesource.com/22962
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
src/os/os_unix_test.go

index c47f5462ab56c874bd921593fd7db12dc4ba46a4..5c10154760cbe756b7548854eb33529cdb4d9ce7 100644 (file)
@@ -145,6 +145,9 @@ func TestLchown(t *testing.T) {
 
        linkname := f.Name() + "2"
        if err := Symlink(f.Name(), linkname); err != nil {
+               if runtime.GOOS == "android" && IsPermission(err) {
+                       t.Skip("skipping test on Android; permission error creating symlink")
+               }
                t.Fatalf("link %s -> %s: %v", f.Name(), linkname, err)
        }
        defer Remove(linkname)