cmd/link/internal/ld: use linkerFlagSupported to check -Qunused-arguments

Rather than checking the linker name or its path for the string "clang",
use linkerFlagSupported to determine whether the -Qunused-arguments flag
may be passed to the linker.

Fixes #45241

Change-Id: I4c1e4d4ecba4cf5823e8f39cfda5d20404ebf513
Reviewed-on: https://go-review.googlesource.com/c/go/+/304692
Trust: Tobias Klauser <tobias.klauser@gmail.com>
Run-TryBot: Tobias Klauser <tobias.klauser@gmail.com>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Than McIntosh <thanm@google.com>

diff --git a/src/cmd/link/internal/ld/lib.go b/src/cmd/link/internal/ld/lib.go
index c80c29a6a851d8f2aa8032241faf0549c90ec9c0..85d0eedecf3a25a27b75ae18c9632945ad273318 100644 (file)
--- a/src/cmd/link/internal/ld/lib.go
+++ b/src/cmd/link/internal/ld/lib.go
@@ -1475,8 +1475,9 @@ func (ctxt *Link) hostlink() {
                argv = append(argv, "-Wl,-bE:"+fileName)
        }
 
-       if strings.Contains(argv[0], "clang") {
-               argv = append(argv, "-Qunused-arguments")
+       const unusedArguments = "-Qunused-arguments"
+       if linkerFlagSupported(ctxt.Arch, argv[0], altLinker, unusedArguments) {
+               argv = append(argv, unusedArguments)
        }
 
        const compressDWARF = "-Wl,--compress-debug-sections=zlib-gnu"