]> Cypherpunks repositories - gostls13.git/commitdiff
asn1: marshal true as 255, not 1.
authorAdam Langley <agl@golang.org>
Sat, 5 Feb 2011 18:55:37 +0000 (13:55 -0500)
committerAdam Langley <agl@golang.org>
Sat, 5 Feb 2011 18:55:37 +0000 (13:55 -0500)
OS X, at least, appears to test |byte == 255|, not |byte != 0| to
establish if a bool is true or false.

R=golang-dev, r
CC=golang-dev
https://golang.org/cl/4128064

src/pkg/asn1/marshal.go

index 24548714b211443b26034de6e8ebb2f094e37c54..57b8f20ba7f00a8090e106089a35b73b50a2c261 100644 (file)
@@ -317,7 +317,7 @@ func marshalBody(out *forkableWriter, value reflect.Value, params fieldParameter
        switch v := value.(type) {
        case *reflect.BoolValue:
                if v.Get() {
-                       return out.WriteByte(1)
+                       return out.WriteByte(255)
                } else {
                        return out.WriteByte(0)
                }