]> Cypherpunks repositories - gostls13.git/commitdiff
cmd/dist: disable plugin test on arm64
authorDavid Crawshaw <crawshaw@golang.org>
Fri, 16 Sep 2016 22:53:46 +0000 (18:53 -0400)
committerDavid Crawshaw <crawshaw@golang.org>
Fri, 16 Sep 2016 23:55:35 +0000 (23:55 +0000)
Mysterious error and no time or easy machine access to investigate
now, so disabling the -buildmode=plugin test on arm64. (The arm
version is working as expected.)

Updates #17138

Change-Id: I4cc56ddf47e7597213462e48d4934a765168bd07
Reviewed-on: https://go-review.googlesource.com/29363
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
src/cmd/dist/test.go

index 2c114be93ffdae03726bb5f67a4d0ee201ecda96..42fd914bb1bfa2a41f815e97574742d271a3e233 100644 (file)
@@ -746,8 +746,10 @@ func (t *tester) supportedBuildmode(mode string) bool {
                }
                return false
        case "plugin":
+               // linux-arm64 is missing because it causes the external linker
+               // to crash, see https://golang.org/issue/17138
                switch pair {
-               case "linux-386", "linux-amd64", "linux-arm", "linux-arm64":
+               case "linux-386", "linux-amd64", "linux-arm":
                        return true
                }
                return false