]> Cypherpunks repositories - gostls13.git/commitdiff
cmd/compile: update comments with ABI aliases/wrappers
authorCherry Mui <cherryyz@google.com>
Wed, 22 Sep 2021 17:23:47 +0000 (13:23 -0400)
committerCherry Mui <cherryyz@google.com>
Wed, 22 Sep 2021 19:37:42 +0000 (19:37 +0000)
ABI aliases are gone.

Change-Id: I0f5676d8730cac14b7495dd6c0c1e08ca85a1c77
Reviewed-on: https://go-review.googlesource.com/c/go/+/351531
Trust: Cherry Mui <cherryyz@google.com>
Reviewed-by: Than McIntosh <thanm@google.com>
src/cmd/compile/internal/ssagen/abi.go
src/cmd/compile/internal/staticdata/data.go

index eabd23279174a404b042428c849398519d385f29..3a653e46b4b542c744feaf90b780e78cafee76b1 100644 (file)
@@ -218,8 +218,6 @@ func (s *SymABIs) GenABIWrappers() {
                }
 
                if !buildcfg.Experiment.RegabiWrappers {
-                       // We'll generate ABI aliases instead of
-                       // wrappers once we have LSyms in InitLSym.
                        continue
                }
 
@@ -251,10 +249,9 @@ func InitLSym(f *ir.Func, hasBody bool) {
                        // the funcsym for either the defining
                        // function or its wrapper as appropriate.
                        //
-                       // If we're using ABI aliases instead of
-                       // wrappers, we only InitLSym for the defining
-                       // ABI of a function, so we make the funcsym
-                       // when we see that.
+                       // If we're not using ABI wrappers, we only
+                       // InitLSym for the defining ABI of a function,
+                       // so we make the funcsym when we see that.
                        staticdata.NeedFuncSym(f)
                }
        }
index f25d8d8ec541f8a68aea5a513e4ae222397549fa..57c15a34a0cd4c82bc1add58b3eb61dfeea8a6a9 100644 (file)
@@ -279,7 +279,7 @@ func NeedFuncSym(fn *ir.Func) {
                // entry points, so it doesn't make sense to create a
                // funcsym for other ABIs.
                //
-               // (If we're using ABI aliases, it doesn't matter.)
+               // (If we're not using ABI wrappers, it doesn't matter.)
                base.Fatalf("expected ABIInternal: %v has %v", fn.Nname, fn.ABI)
        }
        if ir.IsBlank(fn.Nname) {