]> Cypherpunks repositories - gostls13.git/commitdiff
cmd/internal/gc: make Node.Hasbreak a bool
authorDave Cheney <dave@cheney.net>
Thu, 5 Mar 2015 06:19:54 +0000 (17:19 +1100)
committerDave Cheney <dave@cheney.net>
Fri, 6 Mar 2015 06:53:04 +0000 (06:53 +0000)
Node.Hasbreak was treated like a bool, so declare it as bool.

Change-Id: Ied238356dce4da896834bd1412cc21ea56d35e1d
Reviewed-on: https://go-review.googlesource.com/6807
Reviewed-by: Ian Lance Taylor <iant@golang.org>
src/cmd/internal/gc/syntax.go
src/cmd/internal/gc/typecheck.go

index f209afd41fcfea9f3e30334252b2a26e8bcce6b0..6303502af009d214b14d53680a1bef097f0063c2 100644 (file)
@@ -55,7 +55,7 @@ type Node struct {
        Wrapper        uint8 // is method wrapper (for func)
        Reslice        uint8 // this is a reslice x = x[0:y] or x = append(x, ...)
        Likely         int8  // likeliness of if statement
-       Hasbreak       uint8 // has break statement
+       Hasbreak       bool  // has break statement
        Needzero       bool  // if it contains pointers, needs to be zeroed on function entry
        Needctxt       bool  // function uses context register (has closure variables)
        Esc            uint  // EscXXX
index 5ae418ca2ec16fd323b918cf11ca757f8e4b4068..764b3339802de90a93b4d4f3f6d451d7dd090fe9 100644 (file)
@@ -3954,12 +3954,12 @@ func markbreak(n *Node, implicit *Node) {
        case OBREAK:
                if n.Left == nil {
                        if implicit != nil {
-                               implicit.Hasbreak = 1
+                               implicit.Hasbreak = true
                        }
                } else {
                        lab := n.Left.Sym.Label
                        if lab != nil {
-                               lab.Def.Hasbreak = 1
+                               lab.Def.Hasbreak = true
                        }
                }
 
@@ -4053,7 +4053,7 @@ func isterminating(l *NodeList, top int) bool {
                if n.Ntest != nil {
                        return false
                }
-               if n.Hasbreak != 0 {
+               if n.Hasbreak {
                        return false
                }
                return true
@@ -4064,7 +4064,7 @@ func isterminating(l *NodeList, top int) bool {
        case OSWITCH,
                OTYPESW,
                OSELECT:
-               if n.Hasbreak != 0 {
+               if n.Hasbreak {
                        return false
                }
                def := 0