cmd/go: accept hash-style in LDFLAGS

Change-Id: I493bb7e5e9a9e1752236dea1e032b317da7f67f1
Reviewed-on: https://go-review.googlesource.com/c/go/+/211560
Reviewed-by: Ian Lance Taylor <iant@golang.org>
Run-TryBot: Ian Lance Taylor <iant@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>

diff --git a/src/cmd/go/internal/work/security.go b/src/cmd/go/internal/work/security.go
index 2097cd46ff63c9100b909e92c0fc3a88299e4d95..b5e4d46f34b52953ad50342cad0d863ec7f73acb 100644 (file)
--- a/src/cmd/go/internal/work/security.go
+++ b/src/cmd/go/internal/work/security.go
@@ -186,6 +186,7 @@ var validLinkerFlags = []*lazyregexp.Regexp{
        re(`-Wl,--(no-)?export-dynamic`),
        re(`-Wl,-E`),
        re(`-Wl,-framework,[^,@\-][^,]+`),
+       re(`-Wl,--hash-style=(sysv|gnu|both)`),
        re(`-Wl,-headerpad_max_install_names`),
        re(`-Wl,--no-undefined`),
        re(`-Wl,-R([^@\-][^,@]*$)`),

diff --git a/src/cmd/go/internal/work/security_test.go b/src/cmd/go/internal/work/security_test.go
index 6b85c40b13bc9750ab930b4dc59503359bbd71a0..11e74f29c6a6a7f94c6eec7bb403537a726f762e 100644 (file)
--- a/src/cmd/go/internal/work/security_test.go
+++ b/src/cmd/go/internal/work/security_test.go
@@ -131,6 +131,7 @@ var goodLinkerFlags = [][]string{
        {"-mtune=happybirthday"},
        {"-pic"},
        {"-pthread"},
+       {"-Wl,--hash-style=both"},
        {"-Wl,-rpath,foo"},
        {"-Wl,-rpath,$ORIGIN/foo"},
        {"-Wl,-R", "/foo"},
@@ -208,6 +209,7 @@ var badLinkerFlags = [][]string{
        {"-Wl,-framework", "-Wl,@Home"},
        {"-Wl,-framework", "@Home"},
        {"-Wl,-framework,Chocolate,@Home"},
+       {"-Wl,--hash-style=foo"},
        {"-x", "--c"},
        {"-x", "@obj"},
        {"-Wl,-rpath,@foo"},