]> Cypherpunks repositories - gostls13.git/commitdiff
os: fix 63703.md release notes
authorqmuntal <quimmuntal@gmail.com>
Tue, 5 Mar 2024 14:55:27 +0000 (15:55 +0100)
committerQuim Muntal <quimmuntal@gmail.com>
Tue, 5 Mar 2024 16:20:15 +0000 (16:20 +0000)
63703.md contains a paragraph that shouldn't be there,
remove it.

While here, fix a test error message related to the #63703
implementation.

Updates #63703.

Change-Id: I82a8b0b7dfa8f96530fb9a3a3aa971e03970f168
Reviewed-on: https://go-review.googlesource.com/c/go/+/569195
Reviewed-by: Michael Knyszek <mknyszek@google.com>
Reviewed-by: Bryan Mills <bcmills@google.com>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>

doc/next/6-stdlib/99-minor/os/63703.md
src/os/os_windows_test.go

index 581ea142ab576b5e596a6b8b12509f37c1b6dfd0..abde9448f5618f4cf8b06b31d49982ce99100b1a 100644 (file)
@@ -1,10 +1,4 @@
-On Windows, the [`os.Readlink`](/os#Readlink) function no longer tries
-to resolve mount points to a canonical path.
-This behavior is controlled by the `winsymlink` setting.
-For Go 1.23, it defaults to `winsymlink=1`.
-Previous versions default to `winsymlink=0`.
-
-On Windows, [`os.Readlink`](/pkg/path/filepath#EvalSymlinks) no longer tries
+On Windows, [`os.Readlink`](/os#Readlink) no longer tries
 to normalize volumes to drive letters, which was not always even possible.
 This behavior is controlled by the `winreadlinkvolume` setting.
 For Go 1.23, it defaults to `winreadlinkvolume=1`.
index 7e8b8bbf1f04b2f7e2358b5529e5ac669d87ba6d..956ab07f51b84b063002accda08fe3b9ecb79faf 100644 (file)
@@ -172,7 +172,7 @@ func testDirLinks(t *testing.T, tests []dirLinkTest) {
                        wantType = fs.ModeSymlink
                }
                if tp := fi2.Mode().Type(); tp != wantType {
-                       t.Errorf("Lstat(%q) is type %v; want %v", link, tp, fs.ModeDir)
+                       t.Errorf("Lstat(%q) is type %v; want %v", link, tp, wantType)
                }
        }
 }