]> Cypherpunks repositories - gostls13.git/commitdiff
runtime: skip TestGdbPanic on Windows
authorqmuntal <quimmuntal@gmail.com>
Fri, 3 Mar 2023 15:04:56 +0000 (16:04 +0100)
committerGopher Robot <gobot@golang.org>
Fri, 3 Mar 2023 15:35:48 +0000 (15:35 +0000)
TestGdbPanic expects crash() to raise a SIGABRT signal interceptable
by gdb, but Windows doesn't have signals.

Windows builders haven't caught this failing test because they still
don't have gdb installed (tracked in #22021).

Change-Id: I7c7f2523a54d61aea0a9821c4db7c79e58a7217c
Reviewed-on: https://go-review.googlesource.com/c/go/+/473116
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
Run-TryBot: Quim Muntal <quimmuntal@gmail.com>
Reviewed-by: Bryan Mills <bcmills@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Auto-Submit: Quim Muntal <quimmuntal@gmail.com>

src/runtime/runtime-gdb_test.go

index 5af3b7455e1baacbbd3ce3e419ec15e07ba327a6..1577d0995d8d4eeddf61d5ddfb90a47a97a2bb2f 100644 (file)
@@ -661,6 +661,10 @@ func TestGdbPanic(t *testing.T) {
        t.Parallel()
        checkGdbVersion(t)
 
+       if runtime.GOOS == "windows" {
+               t.Skip("no signals on windows")
+       }
+
        dir := t.TempDir()
 
        // Build the source code.