]> Cypherpunks repositories - gostls13.git/commitdiff
cmd/dist: list only supported platforms
authorTobias Klauser <tklauser@distanz.ch>
Fri, 28 Dec 2018 10:46:35 +0000 (11:46 +0100)
committerTobias Klauser <tobias.klauser@gmail.com>
Wed, 2 Jan 2019 19:31:05 +0000 (19:31 +0000)
Introduce an incomplete map in dist alongside cgoEnabled and filter out
the incomplete ports in 'dist list'.

Fixes #28944

Change-Id: I15aae56aec570e1cd9e28906900cd5ba0db77811
Reviewed-on: https://go-review.googlesource.com/c/155839
Run-TryBot: Tobias Klauser <tobias.klauser@gmail.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
src/cmd/dist/build.go
src/cmd/dist/test.go

index da677c81ada5a3e7dfe4a77b6ada2bacfcd6b68f..ad2c96436a069d3510ba0cc191b44994891ca5b5 100644 (file)
@@ -1458,6 +1458,13 @@ var cgoEnabled = map[string]bool{
        "windows/arm":     false,
 }
 
+// List of platforms which are supported but not complete yet. These get
+// filtered out of cgoEnabled for 'dist list'. See golang.org/issue/28944
+var incomplete = map[string]bool{
+       "linux/riscv64": true,
+       "linux/sparc64": true,
+}
+
 func needCC() bool {
        switch os.Getenv("CGO_ENABLED") {
        case "1":
@@ -1576,6 +1583,9 @@ func cmdlist() {
 
        var plats []string
        for p := range cgoEnabled {
+               if incomplete[p] {
+                       continue
+               }
                plats = append(plats, p)
        }
        sort.Strings(plats)
index 82e2e17424f5d38a98253a401261f24620d0030a..74cee8f42169bcbbf8326b3e081d86039bf7c737 100644 (file)
@@ -212,6 +212,9 @@ func (t *tester) run() {
        if t.failed {
                fmt.Println("\nFAILED")
                os.Exit(1)
+       } else if incomplete[goos+"/"+goarch] {
+               fmt.Println("\nFAILED (incomplete port)")
+               os.Exit(1)
        } else if t.partial {
                fmt.Println("\nALL TESTS PASSED (some were excluded)")
        } else {