]> Cypherpunks repositories - gostls13.git/commitdiff
syscall: enable TestSyscallNoError on all Linux 32-bit architectures
authorTobias Klauser <tklauser@distanz.ch>
Mon, 17 Sep 2018 15:22:48 +0000 (17:22 +0200)
committerTobias Klauser <tobias.klauser@gmail.com>
Mon, 17 Sep 2018 16:22:04 +0000 (16:22 +0000)
Check the size of uintptr instead of listing GOARCHes explicitly. This
will make the test also run on linux/mips{,le}.

Change-Id: I649f15d293002afc1360b1913910202c3e5188b7
Reviewed-on: https://go-review.googlesource.com/135715
Run-TryBot: Tobias Klauser <tobias.klauser@gmail.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
src/syscall/syscall_linux_test.go

index 1fd70b07e3ef55f5f3db3100089484870ee69bc7..293549a841d05a5124555d12566c1a256a5d0f2e 100644 (file)
@@ -19,6 +19,7 @@ import (
        "syscall"
        "testing"
        "time"
+       "unsafe"
 )
 
 // chtmpdir changes the working directory to a new temporary directory and
@@ -294,7 +295,7 @@ func TestSyscallNoError(t *testing.T) {
        // On Linux there are currently no syscalls which don't fail and return
        // a value larger than 0xfffffffffffff001 so we could test RawSyscall
        // vs. RawSyscallNoError on 64bit architectures.
-       if runtime.GOARCH != "386" && runtime.GOARCH != "arm" {
+       if unsafe.Sizeof(uintptr(0)) != 4 {
                t.Skip("skipping on non-32bit architecture")
        }