]> Cypherpunks repositories - gostls13.git/commitdiff
syscall: comment on fields omitted from the win32finddata1 struct
authorBryan C. Mills <bcmills@google.com>
Fri, 15 Jan 2021 14:48:39 +0000 (09:48 -0500)
committerBryan C. Mills <bcmills@google.com>
Thu, 25 Feb 2021 22:38:21 +0000 (22:38 +0000)
Updates #42637

Change-Id: I4c7d38034b60c2c04efdeb530a97d96deddfd6fe
Reviewed-on: https://go-review.googlesource.com/c/go/+/284152
Trust: Bryan C. Mills <bcmills@google.com>
Trust: Jason A. Donenfeld <Jason@zx2c4.com>
Trust: Alex Brainman <alex.brainman@gmail.com>
Run-TryBot: Bryan C. Mills <bcmills@google.com>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Jason A. Donenfeld <Jason@zx2c4.com>
Reviewed-by: Alex Brainman <alex.brainman@gmail.com>
src/syscall/types_windows.go

index 0349f3b180dea04ab0356a3ed81bc9d01b1ba5b6..5fef5c94774c8910a18d656a5602871b1d1dfe21 100644 (file)
@@ -398,6 +398,14 @@ type win32finddata1 struct {
        Reserved1         uint32
        FileName          [MAX_PATH]uint16
        AlternateFileName [14]uint16
+
+       // The Microsoft documentation for this struct¹ describes three additional
+       // fields: dwFileType, dwCreatorType, and wFinderFlags. However, those fields
+       // are empirically only present in the macOS port of the Win32 API,² and thus
+       // not needed for binaries built for Windows.
+       //
+       // ¹ https://docs.microsoft.com/en-us/windows/win32/api/minwinbase/ns-minwinbase-win32_find_dataw
+       // ² https://golang.org/issue/42637#issuecomment-760715755
 }
 
 func copyFindData(dst *Win32finddata, src *win32finddata1) {