encoding/gob: close files used in dump.go and encgen.go

Change-Id: Ic1dd899fa52fdf9098955fc14a828d2f07da8037
GitHub-Last-Rev: 6e0438ec7178382e2a7d56f0a053cec33fbe9e78
GitHub-Pull-Request: golang/go#66437
Reviewed-on: https://go-review.googlesource.com/c/go/+/573235
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: David Chase <drchase@google.com>
Reviewed-by: Ian Lance Taylor <iant@google.com>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Run-TryBot: Rob Pike <r@golang.org>
Auto-Submit: Ian Lance Taylor <iant@google.com>
Reviewed-by: Rob Pike <r@golang.org>

diff --git a/src/encoding/gob/dump.go b/src/encoding/gob/dump.go
index f4b1bebfba1dcc0a5506b95f2b449a92f377a09d..b14d84164bcffdb9a20f2843d995dd18c713144a 100644 (file)
--- a/src/encoding/gob/dump.go
+++ b/src/encoding/gob/dump.go
@@ -24,6 +24,7 @@ func main() {
                        fmt.Fprintf(os.Stderr, "dump: %s\n", err)
                        os.Exit(1)
                }
+               defer file.Close()
        }
        gob.Debug(file)
 }

diff --git a/src/encoding/gob/encgen.go b/src/encoding/gob/encgen.go
index e5f68786a0607f66fdaf8ab875ab71546eb7e826..64f5c69bd44dfef86a671efc4d9db7579d4503f3 100644 (file)
--- a/src/encoding/gob/encgen.go
+++ b/src/encoding/gob/encgen.go
@@ -170,6 +170,9 @@ func main() {
        if _, err := fd.Write(source); err != nil {
                log.Fatal(err)
        }
+       if err := fd.Close(); err != nil {
+               log.Fatal(err)
+       }
 }
 
 func printMaps(b *bytes.Buffer, upperClass string) {