]> Cypherpunks repositories - gostls13.git/commitdiff
cmd/go: fix check for -Wp,-U in cgo CFLAGS
authorTobias Klauser <tklauser@distanz.ch>
Thu, 5 Dec 2019 22:55:39 +0000 (23:55 +0100)
committerIan Lance Taylor <iant@golang.org>
Fri, 6 Dec 2019 03:14:41 +0000 (03:14 +0000)
There should be no space after comma.

Change-Id: I6a5c85a386d9d1611b71d5b15a31a00c24c316b4
Reviewed-on: https://go-review.googlesource.com/c/go/+/210120
Run-TryBot: Tobias Klauser <tobias.klauser@gmail.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Ian Lance Taylor <iant@golang.org>
src/cmd/go/internal/work/security.go
src/cmd/go/internal/work/security_test.go

index d02630155bf135b9ab23721bb3e12b79238a5960..0ce1664c16fa9be4fa3879123c5b77709132760b 100644 (file)
@@ -52,7 +52,7 @@ var validCompilerFlags = []*lazyregexp.Regexp{
        re(`-W([^@,]+)`), // -Wall but not -Wa,-foo.
        re(`-Wa,-mbig-obj`),
        re(`-Wp,-D([A-Za-z_].*)`),
-       re(`-Wp, -U([A-Za-z_]*)`),
+       re(`-Wp,-U([A-Za-z_]*)`),
        re(`-ansi`),
        re(`-f(no-)?asynchronous-unwind-tables`),
        re(`-f(no-)?blocks`),
index 3a02db1d04ae169fe436256395a3f802067357ce..6b85c40b13bc9750ab930b4dc59503359bbd71a0 100644 (file)
@@ -22,6 +22,8 @@ var goodCompilerFlags = [][]string{
        {"-Osmall"},
        {"-W"},
        {"-Wall"},
+       {"-Wp,-Dfoo=bar"},
+       {"-Wp,-Ufoo"},
        {"-fobjc-arc"},
        {"-fno-objc-arc"},
        {"-fomit-frame-pointer"},