]> Cypherpunks repositories - gostls13.git/commitdiff
[release-branch.go1.19] cmd/pprof: skip TestDisasm on ARM64
authorCherry Mui <cherryyz@google.com>
Thu, 8 Jun 2023 15:48:38 +0000 (11:48 -0400)
committerGopher Robot <gobot@golang.org>
Mon, 19 Jun 2023 15:52:13 +0000 (15:52 +0000)
The test is fixed at tip, but it is non-trivial enough to backport
to (potentionally the last) Go 1.19 minor release. Skip the test.

Fixes #60637.

Change-Id: I0425b703a5270b680346b63ab38c47b890a3a3bf
Reviewed-on: https://go-review.googlesource.com/c/go/+/501824
TryBot-Result: Gopher Robot <gobot@golang.org>
Auto-Submit: Dmitri Shuralyov <dmitshur@google.com>
Run-TryBot: Cherry Mui <cherryyz@google.com>
Reviewed-by: Michael Knyszek <mknyszek@google.com>
src/cmd/pprof/pprof_test.go

index 9a37b972864115546ea153e88d4b8f2d63a6d2ab..5c7b19d926ba3001e32679bde1263b25acbf65f1 100644 (file)
@@ -99,6 +99,11 @@ func TestDisasm(t *testing.T) {
        mustHaveDisasm(t)
        testenv.MustHaveGoBuild(t)
 
+       if runtime.GOARCH == "arm64" {
+               // Fixed at tip (issue 56574). Skip for Go 1.19 release branch.
+               testenv.SkipFlaky(t, 60637)
+       }
+
        tmpdir := t.TempDir()
        cpuExe := filepath.Join(tmpdir, "cpu.exe")
        cmd := exec.Command(testenv.GoToolPath(t), "build", "-o", cpuExe, "cpu.go")