]> Cypherpunks repositories - gostls13.git/commitdiff
cmd/go/internal/modfetch: do not panic when zip is incorrect
authormarwan-at-work <marwan.sameer@gmail.com>
Sun, 22 Jul 2018 20:23:29 +0000 (20:23 +0000)
committerBrad Fitzpatrick <bradfitz@golang.org>
Mon, 23 Jul 2018 16:05:04 +0000 (16:05 +0000)
Fixes #26536

Change-Id: I75d284bd39af0a06e31d18c7f7745c5a8ecbe6ac
GitHub-Last-Rev: 88040a9edb0cb547a498cb8c8b662eb8729eb8bf
GitHub-Pull-Request: golang/go#26537
Reviewed-on: https://go-review.googlesource.com/125436
Reviewed-by: Daniel Martí <mvdan@mvdan.cc>
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
Run-TryBot: Daniel Martí <mvdan@mvdan.cc>
TryBot-Result: Gobot Gobot <gobot@golang.org>

src/cmd/go/internal/modfetch/fetch.go

index 110312bbe04d78389a744ee6ee848ed1a8a8daee..375c3f1478e79ec91f9c7c79aa47cf3447775cbd 100644 (file)
@@ -90,7 +90,6 @@ func downloadZip(mod module.Version, target string) error {
        // Double-check zip file looks OK.
        z, err := zip.OpenReader(tmpfile)
        if err != nil {
-               z.Close()
                return err
        }
        prefix := mod.Path + "@" + mod.Version