]> Cypherpunks repositories - gostls13.git/commitdiff
runtime: fix brk_ signature for plan9
authormischief <mischief@offblast.org>
Mon, 15 Dec 2014 20:55:00 +0000 (12:55 -0800)
committerDavid du Colombier <0intro@gmail.com>
Sat, 20 Dec 2014 21:41:44 +0000 (21:41 +0000)
with uintptr, the check for < 0 will never succeed in mem_plan9.go's
sbrk() because the brk_ syscall returns -1 on failure. fixes the plan9/amd64 build.

this failed on plan9/amd64 because of the attempt to allocate 136GB in mallocinit(),
which failed. it was just by chance that on plan9/386 allocations never failed.

Change-Id: Ia3059cf5eb752e20d9e60c9619e591b80e8fb03c
Reviewed-on: https://go-review.googlesource.com/1590
Reviewed-by: Anthony Martin <ality@pbrane.org>
Reviewed-by: David du Colombier <0intro@gmail.com>
Reviewed-by: Aram Hăvărneanu <aram@mgk.ro>
src/runtime/os_plan9.go

index 2dcdfc009ab140f7130198bfb6c7c7ed72ab56ff..5a038db497be2d088f88ba331e6c8017750628e6 100644 (file)
@@ -18,7 +18,7 @@ func seek(fd int32, offset int64, whence int32) int64
 func exits(msg *byte)
 
 //go:noescape
-func brk_(addr unsafe.Pointer) uintptr
+func brk_(addr unsafe.Pointer) int32
 
 func sleep(ms int32) int32