]> Cypherpunks repositories - gostls13.git/commitdiff
cmd/go: turn back on build_plugin_reproducible script test
authorThan McIntosh <thanm@google.com>
Tue, 14 May 2024 15:03:30 +0000 (15:03 +0000)
committerThan McIntosh <thanm@google.com>
Tue, 21 May 2024 19:07:03 +0000 (19:07 +0000)
Re-enable the build_plugin_reproducible script test now that CL 586079
(more linker changes to work around xcode problems on Darwin with
build reproducibility) is in.

Fixes #64947.

Cq-Include-Trybots: luci.golang.try:gotip-darwin-amd64-longtest
Change-Id: Ice5bc5b809fa7fee689b78fcb874049493bc2c5c
Reviewed-on: https://go-review.googlesource.com/c/go/+/585356
TryBot-Bypass: Than McIntosh <thanm@google.com>
Reviewed-by: Cherry Mui <cherryyz@google.com>
Reviewed-by: Michael Matloob <matloob@golang.org>
src/cmd/go/testdata/script/build_plugin_reproducible.txt

index 9336bc21a8d34e7c870656fde53119eadb639ab7..3379a6be5f99ceff5589b43f765c14a69b5351d9 100644 (file)
@@ -2,11 +2,6 @@
 [short] skip
 [!cgo] skip '-buildmode=plugin requires external linking'
 
-# This test has problems when run on darwin, when using a more
-# contemporary Xcode version that is unfriendly to reproducible builds
-# (see issue #64947 for the gory details).
-[GOOS:darwin] skip
-
 go build -trimpath -buildvcs=false -buildmode=plugin -o a.so main.go
 go build -trimpath -buildvcs=false -buildmode=plugin -o b.so main.go
 cmp -q a.so b.so