]> Cypherpunks repositories - gostls13.git/commitdiff
encoding/xml: use reflect.Value.Bytes on addressable arrays
authorDaniel Martí <mvdan@mvdan.cc>
Thu, 7 Sep 2023 09:29:14 +0000 (10:29 +0100)
committerDaniel Martí <mvdan@mvdan.cc>
Thu, 7 Sep 2023 19:38:51 +0000 (19:38 +0000)
Since #47066 was accepted and implemented,
reflect.Value.Bytes can be called directly on addressable arrays,
so there is no longer a need to go through a slice first.

Change-Id: I04d50ddb1b38e7a37fee3dc8be1bd03b22a06a1c
Reviewed-on: https://go-review.googlesource.com/c/go/+/526357
Reviewed-by: Joseph Tsai <joetsai@digital-static.net>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Ian Lance Taylor <iant@google.com>
Reviewed-by: Matthew Dempsky <mdempsky@google.com>
src/encoding/xml/marshal.go

index c93e35222d445f18eaab96d604c2cb0c196cc807..5cf12f0888177c0b7f483ddbcd0fb5d53f53e68b 100644 (file)
@@ -797,7 +797,7 @@ func (p *printer) marshalSimple(typ reflect.Type, val reflect.Value) (string, []
                // [...]byte
                var bytes []byte
                if val.CanAddr() {
-                       bytes = val.Slice(0, val.Len()).Bytes()
+                       bytes = val.Bytes()
                } else {
                        bytes = make([]byte, val.Len())
                        reflect.Copy(reflect.ValueOf(bytes), val)