cmd/internal/objfile: only consider executable segments for load address

Reportedly on some new Fedora systems the linker is producing extra
load segments, basically making the dynamic section non-executable.
We were assuming that the first load segment could be used to
determine the program's load offset, but that is no longer true.
Use the first executable load segment instead.

Fixes #26369

Change-Id: I5ee31ddeef2e8caeed3112edc5149065a6448456
Reviewed-on: https://go-review.googlesource.com/127895
Run-TryBot: Ian Lance Taylor <iant@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>

diff --git a/src/cmd/internal/objfile/elf.go b/src/cmd/internal/objfile/elf.go
index 7d5162a1e8944700cd563aea8086d1641a2c0287..a48a9df5d69773be7425d6b11669261caa05e687 100644 (file)
--- a/src/cmd/internal/objfile/elf.go
+++ b/src/cmd/internal/objfile/elf.go
@@ -114,7 +114,7 @@ func (f *elfFile) goarch() string {
 
 func (f *elfFile) loadAddress() (uint64, error) {
        for _, p := range f.elf.Progs {
-               if p.Type == elf.PT_LOAD {
+               if p.Type == elf.PT_LOAD && p.Flags&elf.PF_X != 0 {
                        return p.Vaddr, nil
                }
        }