codereview: warn about 'hg upload' not uploading

This seems to be what causes the 'chunk mismatch' errors.
I don't know why the server tells us there's nothing to upload,
but at the least we can warn that it did, so that the user
will try again.

LGTM=bradfitz
R=golang-codereviews, bradfitz
CC=golang-codereviews
https://golang.org/cl/62840043

diff --git a/lib/codereview/codereview.py b/lib/codereview/codereview.py
index d171ef3e9914edfa15b526681e4d8345ef1bd46b..18ecc141d2c802e01e398d8a9d21242a72a1401a 100644 (file)
--- a/lib/codereview/codereview.py
+++ b/lib/codereview/codereview.py
@@ -367,6 +367,8 @@ class CL(object):
                        msg = lines[0]
                        patchset = lines[1].strip()
                        patches = [x.split(" ", 1) for x in lines[2:]]
+               else:
+                       print >>sys.stderr, "Server says there is nothing to upload (probably wrong):\n" + msg
                if response_body.startswith("Issue updated.") and quiet:
                        pass
                else: