]> Cypherpunks repositories - gostls13.git/commitdiff
net: in TestNotTemporaryRead, reject io.EOF on platforms other than plan9
authorBryan C. Mills <bcmills@google.com>
Mon, 14 Feb 2022 21:07:05 +0000 (16:07 -0500)
committerBryan Mills <bcmills@google.com>
Fri, 1 Apr 2022 21:28:32 +0000 (21:28 +0000)
Updates #29685

Change-Id: Id8dca078213942666871ac8ded663326e98427fe
Reviewed-on: https://go-review.googlesource.com/c/go/+/385754
Reviewed-by: Ian Lance Taylor <iant@golang.org>
Reviewed-by: Emmanuel Odeke <emmanuel@orijtech.com>
Trust: Bryan Mills <bcmills@google.com>
Run-TryBot: Bryan Mills <bcmills@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>

src/net/net_test.go

index 76a9c8b1517cfbe77f1c0064787e74362661491e..fa5ad632bbe5ff0eeea6785a8b9674038d3f2773 100644 (file)
@@ -549,9 +549,7 @@ func TestNotTemporaryRead(t *testing.T) {
                if runtime.GOOS == "plan9" {
                        return
                }
-               // TODO: during an open development cycle, try making this a failure
-               // and see whether it causes the test to become flaky anywhere else.
-               return
+               t.Fatal("Read unexpectedly returned io.EOF after socket was abruptly closed")
        }
        if ne, ok := err.(Error); !ok {
                t.Errorf("Read error does not implement net.Error: %v", err)