]> Cypherpunks repositories - gostls13.git/commitdiff
reflect: adjust MapRange allocation test for noopt builder
authorKeith Randall <khr@golang.org>
Tue, 19 Apr 2022 15:55:04 +0000 (08:55 -0700)
committerKeith Randall <khr@golang.org>
Tue, 19 Apr 2022 17:05:22 +0000 (17:05 +0000)
Change-Id: I55899ff0ed2c3c01f24ab1ccf133ce4236049e39
Reviewed-on: https://go-review.googlesource.com/c/go/+/401074
Run-TryBot: Keith Randall <khr@golang.org>
Reviewed-by: Joseph Tsai <joetsai@digital-static.net>
Reviewed-by: Bryan Mills <bcmills@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Keith Randall <khr@google.com>
src/reflect/all_test.go

index f7adf2fa1a6db2cda25fe28f56ff6432bf8934c8..f18df4e6c508d55fc77da72579e5faa25c4d72c4 100644 (file)
@@ -11,6 +11,7 @@ import (
        "fmt"
        "go/token"
        "internal/goarch"
+       "internal/testenv"
        "io"
        "math"
        "math/rand"
@@ -373,8 +374,12 @@ func TestMapIterSet(t *testing.T) {
        // Calling MapRange should not allocate even though it returns a *MapIter.
        // The function is inlineable, so if the local usage does not escape
        // the *MapIter, it can remain stack allocated.
-       if got != 0 {
-               t.Errorf("wanted 0 alloc, got %d", got)
+       want := 0
+       if strings.HasSuffix(testenv.Builder(), "-noopt") {
+               want = 1 // no inlining with the noopt builder
+       }
+       if got != want {
+               t.Errorf("wanted %d alloc, got %d", want, got)
        }
 }