runtime: disable windowed Smhasher test on 32-bit systems

This test tends to be flaky on 32-bit systems.
There's not enough bits in the hash output, so we
expect a nontrivial number of collisions, and it is
often quite a bit higher than expected.

Fixes #43130

Change-Id: If35413b7c45eed778a08b834dacf98009ceca840
Reviewed-on: https://go-review.googlesource.com/c/go/+/402456
Run-TryBot: Keith Randall <khr@golang.org>
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Ian Lance Taylor <iant@google.com>
Reviewed-by: Keith Randall <khr@google.com>

diff --git a/src/runtime/hash_test.go b/src/runtime/hash_test.go
index cf56c57a5fd6f841978ba1542cc9f3889d6da344..e72600641f2b9ed7df2283b5f5c879a50954a44d 100644 (file)
--- a/src/runtime/hash_test.go
+++ b/src/runtime/hash_test.go
@@ -525,6 +525,13 @@ func windowed(t *testing.T, k Key) {
        if GOARCH == "wasm" {
                t.Skip("Too slow on wasm")
        }
+       if PtrSize == 4 {
+               // This test tends to be flaky on 32-bit systems.
+               // There's not enough bits in the hash output, so we
+               // expect a nontrivial number of collisions, and it is
+               // often quite a bit higher than expected. See issue 43130.
+               t.Skip("Flaky on 32-bit systems")
+       }
        if testing.Short() {
                t.Skip("Skipping in short mode")
        }