]> Cypherpunks repositories - gostls13.git/commitdiff
cmd/compile: fix compilation of math.Sqrt when used as a statement
authorMartin Möhrmann <martisch@uos.de>
Sun, 21 Aug 2016 07:57:01 +0000 (09:57 +0200)
committerMartin Möhrmann <martisch@uos.de>
Sun, 21 Aug 2016 16:49:48 +0000 (16:49 +0000)
Fixes #16804

Change-Id: I669c2c24d3135cd35e15a464894ac66945847d0c
Reviewed-on: https://go-review.googlesource.com/27437
Reviewed-by: Keith Randall <khr@golang.org>
Reviewed-by: Josh Bleecher Snyder <josharian@gmail.com>
Run-TryBot: Keith Randall <khr@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>

src/cmd/compile/internal/gc/ssa.go
test/fixedbugs/issue16804.go [new file with mode: 0644]

index 781fe1b2d5b8678918dda656dd216de44ea8e2fd..304f446df1d45afb33cdd09238368c5f517d1960 100644 (file)
@@ -966,6 +966,9 @@ func (s *state) stmt(n *Node) {
                p := s.expr(n.Left)
                s.nilCheck(p)
 
+       case OSQRT:
+               s.expr(n.Left)
+
        default:
                s.Unimplementedf("unhandled stmt %s", n.Op)
        }
diff --git a/test/fixedbugs/issue16804.go b/test/fixedbugs/issue16804.go
new file mode 100644 (file)
index 0000000..46dd4a3
--- /dev/null
@@ -0,0 +1,16 @@
+// compile
+
+// Copyright 2016 The Go Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style
+// license that can be found in the LICENSE file.
+
+// Issue 16804: internal error for math.Sqrt as statement
+//              rather than expression
+
+package main
+
+import "math"
+
+func sqrt() {
+       math.Sqrt(2.0)
+}