]> Cypherpunks repositories - gostls13.git/commitdiff
debug/gosym: add detailed doc for text argument in NewLineTable
authorZxilly <zxilly@outlook.com>
Wed, 24 Jan 2024 21:27:41 +0000 (21:27 +0000)
committerCherry Mui <cherryyz@google.com>
Thu, 25 Jan 2024 19:43:24 +0000 (19:43 +0000)
Fixes #65232

Change-Id: I9ef76355cec4bea2d77811a69c61c1806c486be8
GitHub-Last-Rev: 9c617b65be9b01e9708e05a540316f98c8a0d165
GitHub-Pull-Request: golang/go#65263
Reviewed-on: https://go-review.googlesource.com/c/go/+/557957
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Cherry Mui <cherryyz@google.com>
Reviewed-by: Carlos Amedee <carlos@golang.org>
src/debug/gosym/pclntab.go

index 6592932622fda384bc25547d0b8f8904014e2770..1d5498e0376a081ef577255d5ca4cd07686d0b54 100644 (file)
@@ -148,7 +148,11 @@ func (t *LineTable) LineToPC(line int, maxpc uint64) uint64 {
 // NewLineTable returns a new PC/line table
 // corresponding to the encoded data.
 // Text must be the start address of the
-// corresponding text segment.
+// corresponding text segment, with the exact
+// value stored in the 'runtime.text' symbol.
+// This value may differ from the start
+// address of the text segment if
+// binary was built with cgo enabled.
 func NewLineTable(data []byte, text uint64) *LineTable {
        return &LineTable{Data: data, PC: text, Line: 0, funcNames: make(map[uint32]string), strings: make(map[uint32]string)}
 }