]> Cypherpunks repositories - gostls13.git/commitdiff
go/types: minor updates to comments to align with types2
authorRob Findley <rfindley@google.com>
Tue, 23 Feb 2021 16:48:15 +0000 (11:48 -0500)
committerRobert Findley <rfindley@google.com>
Tue, 23 Feb 2021 22:57:27 +0000 (22:57 +0000)
Change-Id: Ic4fcd67cd9222eae6b72d9e91e37f3b0293b0b8d
Reviewed-on: https://go-review.googlesource.com/c/go/+/295530
Reviewed-by: Robert Griesemer <gri@golang.org>
Trust: Robert Findley <rfindley@google.com>
Run-TryBot: Robert Findley <rfindley@google.com>
TryBot-Result: Go Bot <gobot@golang.org>

src/go/types/conversions.go
src/go/types/issues_test.go

index 69463f0ca60e1b33b3c253c96e0ac4be384d146d..d93ff465bb853a3173527c808e606ffe818e5d26 100644 (file)
@@ -142,7 +142,7 @@ func isUintptr(typ Type) bool {
 }
 
 func isUnsafePointer(typ Type) bool {
-       // TODO(gri): Is this asBasic() instead of typ.(*Basic) correct?
+       // TODO(gri): Is this asBasic(typ) instead of typ.(*Basic) correct?
        //            (The former calls under(), while the latter doesn't.)
        //            The spec does not say so, but gc claims it is. See also
        //            issue 6326.
index 9ed2934c74dc49b286a64f3b7573eab5cc124cfb..a773a362c7adeec8e79dbd5cbce1e2cfef4ffe15 100644 (file)
@@ -385,9 +385,9 @@ func TestIssue28005(t *testing.T) {
                        }
                }
                if obj == nil {
-                       t.Fatal("interface not found")
+                       t.Fatal("object X not found")
                }
-               iface := obj.Type().Underlying().(*Interface) // I must be an interface
+               iface := obj.Type().Underlying().(*Interface) // object X must be an interface
 
                // Each iface method m is embedded; and m's receiver base type name
                // must match the method's name per the choice in the source file.