]> Cypherpunks repositories - gostls13.git/commitdiff
cmd/go: remove TestCoverageUsesActualSettingToOverrideEvenForRace
authorIan Lance Taylor <iant@golang.org>
Fri, 2 Jun 2017 00:49:55 +0000 (17:49 -0700)
committerIan Lance Taylor <iant@golang.org>
Fri, 2 Jun 2017 04:23:13 +0000 (04:23 +0000)
The test no longer passes as of https://golang.org/cl/43777, which
intentionally disables the feature that this test was checking for.
Nobody noticed since the test is not run in -short mode.

Updates #20435.

Change-Id: I64f37fd94c01f22ead88470b6d9bfe8a151ddb1c
Reviewed-on: https://go-review.googlesource.com/44650
Reviewed-by: Mikio Hara <mikioh.mikioh@gmail.com>
src/cmd/go/go_test.go

index 097b61990b0ee9762a77816bd06193ec4a70aa32..4b9a4eece85edb8f3859d5376b75f2e31bddcfb9 100644 (file)
@@ -2204,29 +2204,6 @@ func TestCoverageUsesAtomicModeForRace(t *testing.T) {
        checkCoverage(tg, data)
 }
 
-func TestCoverageUsesActualSettingToOverrideEvenForRace(t *testing.T) {
-       if testing.Short() {
-               t.Skip("don't build libraries for coverage in short mode")
-       }
-       if !canRace {
-               t.Skip("skipping because race detector not supported")
-       }
-
-       tg := testgo(t)
-       defer tg.cleanup()
-       tg.creatingTemp("testdata/cover.out")
-       tg.run("test", "-short", "-race", "-cover", "encoding/binary", "-covermode=count", "-coverprofile=testdata/cover.out")
-       data := tg.getStdout() + tg.getStderr()
-       if out, err := ioutil.ReadFile("testdata/cover.out"); err != nil {
-               t.Error(err)
-       } else {
-               if !bytes.Contains(out, []byte("mode: count")) {
-                       t.Error("missing mode: count")
-               }
-       }
-       checkCoverage(tg, data)
-}
-
 func TestCoverageImportMainLoop(t *testing.T) {
        tg := testgo(t)
        defer tg.cleanup()