]> Cypherpunks repositories - gostls13.git/commitdiff
runtime: disable TestGdbAutotmpTypes in short mode on aix/ppc64
authorClément Chigot <clement.chigot@atos.net>
Thu, 28 Feb 2019 08:13:56 +0000 (09:13 +0100)
committerIan Lance Taylor <iant@golang.org>
Wed, 6 Mar 2019 05:24:55 +0000 (05:24 +0000)
TestGdbAutotmpTypes takes more than one minute due to gdb performances.
Therefore, it must be skipped in short mode.

Change-Id: I253ebce62264cc7367c9b0f6ce9c5088a9994641
Reviewed-on: https://go-review.googlesource.com/c/go/+/164339
Reviewed-by: Bryan C. Mills <bcmills@google.com>
Run-TryBot: Bryan C. Mills <bcmills@google.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>

src/runtime/runtime-gdb_test.go

index d0f905e4d70b5bef6de63d89ad300b3e0926c4d0..d47c7c226227ab20ef2f321030469f701bc07a42 100644 (file)
@@ -36,8 +36,6 @@ func checkGdbEnvironment(t *testing.T) {
                if runtime.GOARCH == "mips" {
                        t.Skip("skipping gdb tests on linux/mips; see https://golang.org/issue/25939")
                }
-       case "aix":
-               t.Skip("gdb does not work on AIX; see https://golang.org/issue/28558")
        case "freebsd":
                t.Skip("skipping gdb tests on FreeBSD; see https://golang.org/issue/29508")
        }
@@ -396,6 +394,10 @@ func TestGdbAutotmpTypes(t *testing.T) {
        t.Parallel()
        checkGdbVersion(t)
 
+       if runtime.GOOS == "aix" && testing.Short() {
+               t.Skip("TestGdbAutotmpTypes is too slow on aix/ppc64")
+       }
+
        dir, err := ioutil.TempDir("", "go-build")
        if err != nil {
                t.Fatalf("failed to create temp directory: %v", err)