]> Cypherpunks repositories - gostls13.git/commitdiff
runtime: listen 127.0.0.1 instead of localhost on android
authorBurcu Dogan <jbd@google.com>
Mon, 7 Mar 2016 21:41:27 +0000 (13:41 -0800)
committerBurcu Dogan <jbd@google.com>
Tue, 8 Mar 2016 00:22:38 +0000 (00:22 +0000)
Fixes #14486.
Related to #14485.

Change-Id: I2dd77b0337aebfe885ae828483deeaacb500b12a
Reviewed-on: https://go-review.googlesource.com/20340
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>

src/runtime/proc_test.go

index 9e5960bd2af612232e58e172d7071d3a1ae7cb98..7064b0edd86282e8ec1869de99ea31999fb8278d 100644 (file)
@@ -178,7 +178,14 @@ func testGoroutineParallelism2(t *testing.T, load, netpoll bool) {
                }
                if netpoll {
                        // Enable netpoller, affects schedler behavior.
-                       ln, err := net.Listen("tcp", "localhost:0")
+                       laddr := "localhost:0"
+                       if runtime.GOOS == "android" {
+                               // On some Android devices, there are no records for localhost,
+                               // see https://golang.org/issues/14486.
+                               // Don't use 127.0.0.1 for every case, it won't work on IPv6-only systems.
+                               laddr = "127.0.0.1:0"
+                       }
+                       ln, err := net.Listen("tcp", laddr)
                        if err != nil {
                                defer ln.Close() // yup, defer in a loop
                        }