[release-branch.go1.13] os/exec: use environment variables for user token when present

Builds upon the changes from #32000 which supported sourcing environment
variables for a new process from the environment of a Windows user token
when supplied.

But due to the logic of os/exec, the Env field of a process was
always non-nil when it reached that change.

This change moves the logic up to os/exec, specifically when
os.ProcAttr is being built for the os.StartProcess call, this
ensures that if a user token has been supplied and no Env slice has
been provided on the command it will be sourced from the user's
environment.

If no token is provided, or the program is compiled for any other
platform than Windows, the default environment will be sourced from
syscall.Environ().

For #35314
Fixes #37433

Change-Id: I4c1722e90b91945eb6980d5c5928183269b50487
GitHub-Last-Rev: 32216b7291418f9285147a93ed6d0ba028f94ef2
GitHub-Pull-Request: golang/go#37402
Reviewed-on: https://go-review.googlesource.com/c/go/+/220587
Run-TryBot: Ian Lance Taylor <iant@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Ian Lance Taylor <iant@golang.org>
Reviewed-on: https://go-review.googlesource.com/c/go/+/226280

diff --git a/src/go/build/deps_test.go b/src/go/build/deps_test.go
index 179b0bfef553ae2008adf9ce0893d066de9779e6..40f29a2c301307aae1952bb35e80f1d0c71b0519 100644 (file)
--- a/src/go/build/deps_test.go
+++ b/src/go/build/deps_test.go
@@ -152,6 +152,7 @@ var pkgDeps = map[string][]string{
        "internal/syscall/unix":             {"L0", "syscall"},
        "internal/syscall/windows":          {"L0", "syscall", "internal/syscall/windows/sysdll"},
        "internal/syscall/windows/registry": {"L0", "syscall", "internal/syscall/windows/sysdll", "unicode/utf16"},
+       "internal/syscall/execenv":          {"L0", "syscall", "internal/syscall/windows", "unicode/utf16"},
        "time": {
                // "L0" without the "io" package:
                "errors",
@@ -169,10 +170,10 @@ var pkgDeps = map[string][]string{
        "internal/cfg":     {"L0"},
        "internal/poll":    {"L0", "internal/oserror", "internal/race", "syscall", "time", "unicode/utf16", "unicode/utf8", "internal/syscall/windows"},
        "internal/testlog": {"L0"},
-       "os":               {"L1", "os", "syscall", "time", "internal/oserror", "internal/poll", "internal/syscall/windows", "internal/syscall/unix", "internal/testlog"},
+       "os":               {"L1", "os", "syscall", "time", "internal/oserror", "internal/poll", "internal/syscall/windows", "internal/syscall/unix", "internal/syscall/execenv", "internal/testlog"},
        "path/filepath":    {"L2", "os", "syscall", "internal/syscall/windows"},
        "io/ioutil":        {"L2", "os", "path/filepath", "time"},
-       "os/exec":          {"L2", "os", "context", "path/filepath", "syscall"},
+       "os/exec":          {"L2", "os", "context", "path/filepath", "syscall", "internal/syscall/execenv"},
        "os/signal":        {"L2", "os", "syscall"},
 
        // OS enables basic operating system functionality,

diff --git a/src/internal/syscall/execenv/execenv_default.go b/src/internal/syscall/execenv/execenv_default.go
new file mode 100644 (file)
index 0000000..4bdbb55
--- /dev/null
+++ b/src/internal/syscall/execenv/execenv_default.go
@@ -0,0 +1,19 @@
+// Copyright 2020 The Go Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style
+// license that can be found in the LICENSE file.
+
+// +build !windows
+
+package execenv
+
+import "syscall"
+
+// Default will return the default environment
+// variables based on the process attributes
+// provided.
+//
+// Defaults to syscall.Environ() on all platforms
+// other than Windows.
+func Default(sys *syscall.SysProcAttr) ([]string, error) {
+       return syscall.Environ(), nil
+}

diff --git a/src/os/env_windows.go b/src/internal/syscall/execenv/execenv_windows.go
similarity index 59%
rename from src/os/env_windows.go
rename to src/internal/syscall/execenv/execenv_windows.go
index e8f647e7ac778e5a2deb82c0d9a226f9c599eace..3a41a7a3fd544181445ab94761ecd9893ed21255 100644 (file)
--- a/src/os/env_windows.go
+++ b/src/internal/syscall/execenv/execenv_windows.go
@@ -1,8 +1,10 @@
-// Copyright 2019 The Go Authors. All rights reserved.
+// Copyright 2020 The Go Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style
 // license that can be found in the LICENSE file.
 
-package os
+// +build windows
+
+package execenv
 
 import (
        "internal/syscall/windows"
@@ -11,9 +13,17 @@ import (
        "unsafe"
 )
 
-func environForSysProcAttr(sys *syscall.SysProcAttr) (env []string, err error) {
+// Default will return the default environment
+// variables based on the process attributes
+// provided.
+//
+// If the process attributes contain a token, then
+// the environment variables will be sourced from
+// the defaults for that user token, otherwise they
+// will be sourced from syscall.Environ().
+func Default(sys *syscall.SysProcAttr) (env []string, err error) {
        if sys == nil || sys.Token == 0 {
-               return Environ(), nil
+               return syscall.Environ(), nil
        }
        var block *uint16
        err = windows.CreateEnvironmentBlock(&block, sys.Token, false)

diff --git a/src/os/env_default.go b/src/os/env_default.go
deleted file mode 100644 (file)
index c11ccce..0000000
--- a/src/os/env_default.go
+++ /dev/null
@@ -1,13 +0,0 @@
-// Copyright 2019 The Go Authors. All rights reserved.
-// Use of this source code is governed by a BSD-style
-// license that can be found in the LICENSE file.
-
-// +build !windows
-
-package os
-
-import "syscall"
-
-func environForSysProcAttr(sys *syscall.SysProcAttr) ([]string, error) {
-       return Environ(), nil
-}

diff --git a/src/os/exec/exec.go b/src/os/exec/exec.go
index 17ef003eca02b435019b7d9ce5cfbd8028e76c9c..5552fd858f10b6ea7ee60b5a0ec28ac37dd3cfc5 100644 (file)
--- a/src/os/exec/exec.go
+++ b/src/os/exec/exec.go
@@ -24,6 +24,7 @@ import (
        "bytes"
        "context"
        "errors"
+       "internal/syscall/execenv"
        "io"
        "os"
        "path/filepath"
@@ -222,11 +223,11 @@ func interfaceEqual(a, b interface{}) bool {
        return a == b
 }
 
-func (c *Cmd) envv() []string {
+func (c *Cmd) envv() ([]string, error) {
        if c.Env != nil {
-               return c.Env
+               return c.Env, nil
        }
-       return os.Environ()
+       return execenv.Default(c.SysProcAttr)
 }
 
 func (c *Cmd) argv() []string {
@@ -412,11 +413,15 @@ func (c *Cmd) Start() error {
        }
        c.childFiles = append(c.childFiles, c.ExtraFiles...)
 
-       var err error
+       envv, err := c.envv()
+       if err != nil {
+               return err
+       }
+
        c.Process, err = os.StartProcess(c.Path, c.argv(), &os.ProcAttr{
                Dir:   c.Dir,
                Files: c.childFiles,
-               Env:   addCriticalEnv(dedupEnv(c.envv())),
+               Env:   addCriticalEnv(dedupEnv(envv)),
                Sys:   c.SysProcAttr,
        })
        if err != nil {

diff --git a/src/os/exec_posix.go b/src/os/exec_posix.go
index 505931b488323b380efe7647654676e9c2bac3cd..83fdae851444c6d456c190713004aa9c55c30be0 100644 (file)
--- a/src/os/exec_posix.go
+++ b/src/os/exec_posix.go
@@ -7,6 +7,7 @@
 package os
 
 import (
+       "internal/syscall/execenv"
        "syscall"
 )
 
@@ -38,7 +39,7 @@ func startProcess(name string, argv []string, attr *ProcAttr) (p *Process, err e
                Sys: attr.Sys,
        }
        if sysattr.Env == nil {
-               sysattr.Env, err = environForSysProcAttr(sysattr.Sys)
+               sysattr.Env, err = execenv.Default(sysattr.Sys)
                if err != nil {
                        return nil, err
                }