]> Cypherpunks repositories - gostls13.git/commitdiff
Revert "cmd/compile: build compiler with PGO"
authorMichael Pratt <mpratt@google.com>
Thu, 18 May 2023 17:12:26 +0000 (17:12 +0000)
committerGopher Robot <gobot@golang.org>
Thu, 18 May 2023 17:25:08 +0000 (17:25 +0000)
This reverts CL 495596.

Reason for revert: duplicate symbol failures in x/tools and random PPC crashes.

Change-Id: I57305f8e72ee1567dc5a6a829c2d70fb5719028a
Reviewed-on: https://go-review.googlesource.com/c/go/+/496185
Reviewed-by: Bryan Mills <bcmills@google.com>
Run-TryBot: Michael Pratt <mpratt@google.com>
Auto-Submit: Michael Pratt <mpratt@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>

src/cmd/compile/default.pgo [deleted file]
src/cmd/compile/profile.sh [deleted file]
src/cmd/dist/buildtool.go

diff --git a/src/cmd/compile/default.pgo b/src/cmd/compile/default.pgo
deleted file mode 100644 (file)
index 2ba7968..0000000
Binary files a/src/cmd/compile/default.pgo and /dev/null differ
diff --git a/src/cmd/compile/profile.sh b/src/cmd/compile/profile.sh
deleted file mode 100644 (file)
index 37d65d8..0000000
+++ /dev/null
@@ -1,21 +0,0 @@
-# Copyright 2023 The Go Authors. All rights reserved.
-# Use of this source code is governed by a BSD-style
-# license that can be found in the LICENSE file.
-
-# This script collects a CPU profile of the compiler
-# for building all targets in std and cmd, and puts
-# the profile at cmd/compile/default.pgo.
-
-dir=$(mktemp -d)
-cd $dir
-seed=$(date)
-
-for p in $(go list std cmd); do
-       h=$(echo $seed $p | md5sum | cut -d ' ' -f 1)
-       echo $p $h
-       go build -o /dev/null -gcflags=-cpuprofile=$PWD/prof.$h $p
-done
-
-go tool pprof -proto prof.* > $(go env GOROOT)/src/cmd/compile/default.pgo
-
-rm -r $dir
index 7ecfb3a811b0e83896accae9bc51ddd832ff909b..af3db5f59023bd9e99fdef6884cac49ca2c3de8d 100644 (file)
@@ -100,10 +100,6 @@ var ignorePrefixes = []string{
 var ignoreSuffixes = []string{
        "_test.s",
        "_test.go",
-       // Skip PGO profile. No need to build toolchain1 compiler
-       // with PGO. And as it is not a text file the import path
-       // rewrite will break it.
-       ".pgo",
 }
 
 var tryDirs = []string{