]> Cypherpunks repositories - gostls13.git/commitdiff
all: use time.Time.Equal instead of == in some tests
authorBrad Fitzpatrick <bradfitz@golang.org>
Thu, 4 May 2017 15:05:33 +0000 (15:05 +0000)
committerBrad Fitzpatrick <bradfitz@golang.org>
Thu, 4 May 2017 15:17:13 +0000 (15:17 +0000)
(Found by making time.Time uncomparable and rerunning std tests
locally.)

Change-Id: I4fa6fb0ba7334965362387e2f6541c17a27ac3aa
Reviewed-on: https://go-review.googlesource.com/42616
Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org>
Reviewed-by: Martin Möhrmann <moehrmann@google.com>
Reviewed-by: Damien Neil <dneil@google.com>
Reviewed-by: Bryan Mills <bcmills@google.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>

src/cmd/go/go_test.go
src/net/dial_test.go
src/net/dnsclient_unix_test.go

index 95579b7b225d53d2ecbd78c19063eb10183c337b..49614a9bef7943c573251538dc80e8465617fa3a 100644 (file)
@@ -3090,7 +3090,7 @@ func TestGoTestRaceInstallCgo(t *testing.T) {
        tg.run("test", "-race", "-i", "runtime/race")
        new, err := os.Stat(cgo)
        tg.must(err)
-       if new.ModTime() != old.ModTime() {
+       if !new.ModTime().Equal(old.ModTime()) {
                t.Fatalf("go test -i runtime/race reinstalled cmd/cgo")
        }
 }
index 669a3685214c2210ef9945fb62d57b8c1edb2c8b..a49a9d742603bfb7085773a16988b8fdc5995c87 100644 (file)
@@ -529,7 +529,7 @@ func TestDialerPartialDeadline(t *testing.T) {
                if err != tt.expectErr {
                        t.Errorf("#%d: got %v; want %v", i, err, tt.expectErr)
                }
-               if deadline != tt.expectDeadline {
+               if !deadline.Equal(tt.expectDeadline) {
                        t.Errorf("#%d: got %v; want %v", i, deadline, tt.expectDeadline)
                }
        }
index e1bbf68e57ff659086236c8ab69bceb6f33aaabb..a23e5f622225bea52b6aef431db9ae3a39699040 100644 (file)
@@ -784,7 +784,7 @@ func TestRetryTimeout(t *testing.T) {
                        return nil, poll.ErrTimeout
                }
 
-               if deadline == deadline0 {
+               if deadline.Equal(deadline0) {
                        t.Error("deadline didn't change")
                }