]> Cypherpunks repositories - gostls13.git/commitdiff
runtime: make go vet happy
authorKeith Randall <khr@golang.org>
Tue, 22 Jul 2014 04:35:48 +0000 (21:35 -0700)
committerKeith Randall <khr@golang.org>
Tue, 22 Jul 2014 04:35:48 +0000 (21:35 -0700)
CL 117950044 updates vet to fix LEA* issue.

LGTM=bradfitz
R=golang-codereviews, bradfitz
CC=golang-codereviews
https://golang.org/cl/112440043

src/pkg/runtime/asm_amd64.s
src/pkg/runtime/asm_amd64p32.s

index 9f8a2514e3171ef26e97d9eb98f1855f0501be38..80fc3b0d36988b7c6f875022b7d3cfc6119d5078 100644 (file)
@@ -2276,7 +2276,7 @@ TEXT runtime·gohash(SB), NOSPLIT, $24-40
        MOVQ    size+16(FP), DX
        MOVQ    seed+24(FP), DI
        MOVQ    DI, ret+32(FP)
-       LEAQ    ret+32(FP), SI  // TODO: go vet complains here: "invalid LEAQ of ret+32(FP); bool is 1-byte value"
+       LEAQ    ret+32(FP), SI
        MOVQ    SI, 0(SP)
        MOVQ    DX, 8(SP)
        MOVQ    CX, 16(SP)
index 097cacb607dbb75467e0f176a2dd89bd07fa4aa7..6a3f033e8bf02d63fec5e74301597ed5c24cd023 100644 (file)
@@ -672,10 +672,10 @@ TEXT runtime·getcallerpc(SB),NOSPLIT,$0-8
        MOVL    -8(AX),AX               // get calling pc
        RET
 
-TEXT runtime·gogetcallerpc(SB),NOSPLIT,$0-8
+TEXT runtime·gogetcallerpc(SB),NOSPLIT,$0-12
        MOVL    p+0(FP),AX              // addr of first arg
        MOVL    -8(AX),AX               // get calling pc
-       MOVL    AX, ret+4(FP)
+       MOVL    AX, ret+8(FP)
        RET
 
 TEXT runtime·setcallerpc(SB),NOSPLIT,$0-16