]> Cypherpunks repositories - gostls13.git/commitdiff
[dev.typeparams] cmd/compile: remove outdate TODO in escape analysis
authorCuong Manh Le <cuong.manhle.vn@gmail.com>
Thu, 22 Jul 2021 17:24:50 +0000 (00:24 +0700)
committerCuong Manh Le <cuong.manhle.vn@gmail.com>
Thu, 22 Jul 2021 17:54:48 +0000 (17:54 +0000)
We now understand the root cause of #47227, it will be fixed in #47317.

Change-Id: Ifcd44f887a0bd3195818df33e409bd3e818e0b27
Reviewed-on: https://go-review.googlesource.com/c/go/+/336610
Trust: Cuong Manh Le <cuong.manhle.vn@gmail.com>
Run-TryBot: Cuong Manh Le <cuong.manhle.vn@gmail.com>
Reviewed-by: Matthew Dempsky <mdempsky@google.com>
TryBot-Result: Go Bot <gobot@golang.org>

src/cmd/compile/internal/escape/call.go

index 65c76d6870b3988067621e08c01c553dda0efb99..9e5abed59142edaf7b6dba120d733f765e4cf6cb 100644 (file)
@@ -320,8 +320,6 @@ func (e *escape) rewriteArgument(argp *ir.Node, init *ir.Nodes, call ir.Node, fn
                        return
                case ir.ONAME:
                        if arg.(*ir.Name).Class == ir.PFUNC {
-                               // TODO(cuonglm): figure it why this is necessary, we should not depend on this to make
-                               //                ABI analyze works correctly (see #47227 and discussion in CL 334882).
                                return
                        }
                }