]> Cypherpunks repositories - gostls13.git/commitdiff
net: use absDomainName in the Windows lookupPTR test helper
authorBryan C. Mills <bcmills@google.com>
Wed, 23 Jun 2021 01:24:57 +0000 (21:24 -0400)
committerBryan C. Mills <bcmills@google.com>
Thu, 24 Jun 2021 00:39:41 +0000 (00:39 +0000)
The real net code uses subtle heuristics to transform a domain name
to its absolute form. Since lookupPTR isn't checking that
transformation specifically, it should use the real code instead of
using a different heuristic.

Fixes #46882

Change-Id: I503357e0f62059c37c359cd54b44d343c7d5ab2a
Reviewed-on: https://go-review.googlesource.com/c/go/+/330249
Trust: Bryan C. Mills <bcmills@google.com>
Trust: Alex Brainman <alex.brainman@gmail.com>
Run-TryBot: Bryan C. Mills <bcmills@google.com>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Alex Brainman <alex.brainman@gmail.com>
Reviewed-by: Ian Lance Taylor <iant@golang.org>
src/net/lookup_windows_test.go

index 62b61ed6c2f3ce9ed43a0bff92358be6a731db34..aa95501d023930d114970e828296e9d10b531d9e 100644 (file)
@@ -299,7 +299,7 @@ func lookupPTR(name string) (ptr []string, err error) {
        ptr = make([]string, 0, 10)
        rx := regexp.MustCompile(`(?m)^Pinging\s+([a-zA-Z0-9.\-]+)\s+\[.*$`)
        for _, ans := range rx.FindAllStringSubmatch(r, -1) {
-               ptr = append(ptr, ans[1]+".")
+               ptr = append(ptr, absDomainName([]byte(ans[1])))
        }
        return
 }