]> Cypherpunks repositories - gostls13.git/commitdiff
debug/elf: fix nil deref in test
authorDmitriy Vyukov <dvyukov@google.com>
Sat, 5 Jul 2014 04:48:46 +0000 (08:48 +0400)
committerDmitriy Vyukov <dvyukov@google.com>
Sat, 5 Jul 2014 04:48:46 +0000 (08:48 +0400)
LGTM=crawshaw
R=golang-codereviews, crawshaw
CC=golang-codereviews
https://golang.org/cl/109470044

src/pkg/debug/elf/file_test.go

index 7f88a54bcd6dec74359f46bddd29cd219f665d64..5e4ad5c100f2375333532dcff73635d048d18d37 100644 (file)
@@ -166,11 +166,11 @@ func TestOpen(t *testing.T) {
                } else {
                        f, err = Open(tt.file)
                }
-               defer f.Close()
                if err != nil {
                        t.Errorf("cannot open file %s: %v", tt.file, err)
                        continue
                }
+               defer f.Close()
                if !reflect.DeepEqual(f.FileHeader, tt.hdr) {
                        t.Errorf("open %s:\n\thave %#v\n\twant %#v\n", tt.file, f.FileHeader, tt.hdr)
                        continue