]> Cypherpunks repositories - gostls13.git/commitdiff
cmd/internal/obj: do not generate data for $f32. and $f64. symbols at assemble time
authorShenghou Ma <minux@golang.org>
Thu, 2 Apr 2015 01:38:05 +0000 (21:38 -0400)
committerMinux Ma <minux@golang.org>
Wed, 29 Apr 2015 04:48:55 +0000 (04:48 +0000)
When reading the object files for linking, liblink takes care of
generate the data for them.

This is a port of https://golang.org/cl/3101 to Go.

Change-Id: Ie3e2d6515bd7d253a8c1e25c70ef8fed064436d8
Signed-off-by: Shenghou Ma <minux@golang.org>
Reviewed-on: https://go-review.googlesource.com/8383
Reviewed-by: Ian Lance Taylor <iant@golang.org>
src/cmd/internal/obj/arm/obj5.go
src/cmd/internal/obj/x86/obj6.go

index 2d3e537ca04eb791ce2b1270b2a22dcf1df040d4..847fce6490ef86d8f350b3c92519846b8edadcdc 100644 (file)
@@ -112,11 +112,6 @@ func progedit(ctxt *obj.Link, p *obj.Prog) {
                        i32 := math.Float32bits(f32)
                        literal := fmt.Sprintf("$f32.%08x", i32)
                        s := obj.Linklookup(ctxt, literal, 0)
-                       if s.Type == 0 {
-                               s.Type = obj.SRODATA
-                               obj.Adduint32(ctxt, s, i32)
-                       }
-
                        p.From.Type = obj.TYPE_MEM
                        p.From.Sym = s
                        p.From.Name = obj.NAME_EXTERN
@@ -128,11 +123,6 @@ func progedit(ctxt *obj.Link, p *obj.Prog) {
                        i64 := math.Float64bits(p.From.Val.(float64))
                        literal := fmt.Sprintf("$f64.%016x", i64)
                        s := obj.Linklookup(ctxt, literal, 0)
-                       if s.Type == 0 {
-                               s.Type = obj.SRODATA
-                               obj.Adduint64(ctxt, s, i64)
-                       }
-
                        p.From.Type = obj.TYPE_MEM
                        p.From.Sym = s
                        p.From.Name = obj.NAME_EXTERN
index 743a48a4944bd09b8b650dcae5cde6a95644050a..7a4fc128e6400cd5998ceb46a243b7cfe8a76205 100644 (file)
@@ -249,11 +249,6 @@ func progedit(ctxt *obj.Link, p *obj.Prog) {
                        i32 := math.Float32bits(f32)
                        literal := fmt.Sprintf("$f32.%08x", i32)
                        s := obj.Linklookup(ctxt, literal, 0)
-                       if s.Type == 0 {
-                               s.Type = obj.SRODATA
-                               obj.Adduint32(ctxt, s, i32)
-                       }
-
                        p.From.Type = obj.TYPE_MEM
                        p.From.Name = obj.NAME_EXTERN
                        p.From.Sym = s
@@ -293,11 +288,6 @@ func progedit(ctxt *obj.Link, p *obj.Prog) {
                        i64 := math.Float64bits(p.From.Val.(float64))
                        literal := fmt.Sprintf("$f64.%016x", i64)
                        s := obj.Linklookup(ctxt, literal, 0)
-                       if s.Type == 0 {
-                               s.Type = obj.SRODATA
-                               obj.Adduint64(ctxt, s, i64)
-                       }
-
                        p.From.Type = obj.TYPE_MEM
                        p.From.Name = obj.NAME_EXTERN
                        p.From.Sym = s