]> Cypherpunks repositories - gostls13.git/commitdiff
bug168 (dsymonds) + fix
authorRuss Cox <rsc@golang.org>
Thu, 9 Jul 2009 19:08:50 +0000 (12:08 -0700)
committerRuss Cox <rsc@golang.org>
Thu, 9 Jul 2009 19:08:50 +0000 (12:08 -0700)
R=ken
OCL=31399
CL=31399

src/cmd/8g/cgen.c
test/fixedbugs/bug168.go [new file with mode: 0644]

index 8c90ad544ece214bf0e8c3f1a08a608df4d350de..474d0713f445621bdce904648563ccb96051a4e7 100644 (file)
@@ -91,17 +91,12 @@ cgen(Node *n, Node *res)
 
        // if both are not addressable, use a temporary.
        if(!n->addable && !res->addable) {
-               if(is64(n->type)) {
-                       tempalloc(&n1, n->type);
-                       cgen(n, &n1);
-                       cgen(&n1, res);
-                       tempfree(&n1);
-                       return;
-               }
-               regalloc(&n1, n->type, N);
+               // could use regalloc here sometimes,
+               // but have to check for ullman >= UINF.
+               tempalloc(&n1, n->type);
                cgen(n, &n1);
                cgen(&n1, res);
-               regfree(&n1);
+               tempfree(&n1);
                return;
        }
 
diff --git a/test/fixedbugs/bug168.go b/test/fixedbugs/bug168.go
new file mode 100644 (file)
index 0000000..221eb55
--- /dev/null
@@ -0,0 +1,18 @@
+// $G $D/$F.go && $L $F.$A && ./$A.out || echo BUG: bug168
+
+// Copyright 2009 The Go Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style
+// license that can be found in the LICENSE file.
+
+package main
+
+var g byte = 123;
+var f *byte = &g;
+var b = make([]byte, 5);
+
+func main() {
+       b[0:1][0] = *f;
+       if b[0] != 123 {
+               panic("want 123 got ", b[0]);
+       }       
+}