]> Cypherpunks repositories - gostls13.git/commitdiff
cmd/go: document import "C" check from CL 129062
authorRuss Cox <rsc@golang.org>
Fri, 17 Aug 2018 14:54:20 +0000 (10:54 -0400)
committerRuss Cox <rsc@golang.org>
Fri, 17 Aug 2018 14:56:26 +0000 (14:56 +0000)
Added this locally but then broke the first rule of Gerrit
and clicked Submit instead of running "git submit".

Change-Id: I83c28d9151c566e9b2092e2613d67731a5d64beb
Reviewed-on: https://go-review.googlesource.com/129678
Run-TryBot: Russ Cox <rsc@golang.org>
Reviewed-by: Russ Cox <rsc@golang.org>
src/cmd/go/internal/imports/scan.go

index bae6b934bcad2daf57113918d61e6746a8997e7d..d944e95724e54244e28f9694e8dbb6780db18f3d 100644 (file)
@@ -49,12 +49,19 @@ Files:
                if err != nil {
                        return nil, nil, fmt.Errorf("reading %s: %v", name, err)
                }
-               // import "C" is implicit requirement of cgo tag
+
+               // import "C" is implicit requirement of cgo tag.
+               // When listing files on the command line (explicitFiles=true)
+               // we do not apply build tag filtering but we still do apply
+               // cgo filtering, so no explicitFiles check here.
+               // Why? Because we always have, and it's not worth breaking
+               // that behavior now.
                for _, path := range list {
                        if path == `"C"` && !tags["cgo"] && !tags["*"] {
                                continue Files
                        }
                }
+
                if !explicitFiles && !ShouldBuild(data, tags) {
                        continue
                }