]> Cypherpunks repositories - gostls13.git/commitdiff
net: Increase the acceptable delay in TestDialerDualstack
authorPaul Marks <pmarks@google.com>
Mon, 31 Aug 2015 20:30:22 +0000 (13:30 -0700)
committerBrad Fitzpatrick <bradfitz@golang.org>
Mon, 31 Aug 2015 21:36:04 +0000 (21:36 +0000)
This may fix the flakiness on Windows/x64, assuming that it's actually
due to a variance in the connection time which slightly exceeds 100ms.

150ms + 95ms = 245ms, which is still low enough to avoid triggering
Happy Eyeballs (300ms) on non-Windows platforms.

Updates #12309

Change-Id: I816a36fbc0a3e5c90e3cf1b75a134faf0d91557c
Reviewed-on: https://go-review.googlesource.com/14120
Run-TryBot: Paul Marks <pmarks@google.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
src/net/dial_test.go

index ed6d7cc42f135d7a38e204e42e568318efbcf8f6..98433067751a1672aba5688e23e11005d27c2bf2 100644 (file)
@@ -643,7 +643,7 @@ func TestDialerDualStack(t *testing.T) {
                }
        }
 
-       var timeout = 100*time.Millisecond + closedPortDelay
+       var timeout = 150*time.Millisecond + closedPortDelay
        for _, dualstack := range []bool{false, true} {
                dss, err := newDualStackServer([]streamListener{
                        {network: "tcp4", address: "127.0.0.1"},