]> Cypherpunks repositories - gostls13.git/commitdiff
net/http: fix test assertion
authorThomas Bruyelle <thomas.bruyelle@gmail.com>
Fri, 22 Jun 2018 09:16:40 +0000 (11:16 +0200)
committerBrad Fitzpatrick <bradfitz@golang.org>
Fri, 22 Jun 2018 13:28:19 +0000 (13:28 +0000)
Logf doesn't make the test fail, so the test was always OK.

Change-Id: I7c10ee74ff7e5d28cbd3a35e185093cb9f349470
Reviewed-on: https://go-review.googlesource.com/120496
Run-TryBot: Tobias Klauser <tobias.klauser@gmail.com>
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
src/net/http/transfer_test.go

index 9a201aab2d615f2f8126c941ddb74ac58a79daa6..993ea4ef18c449a5332736dc09ccec82e93948a8 100644 (file)
@@ -86,7 +86,7 @@ func TestDetectInMemoryReaders(t *testing.T) {
        for i, tt := range tests {
                got := isKnownInMemoryReader(tt.r)
                if got != tt.want {
-                       t.Logf("%d: got = %v; want %v", i, got, tt.want)
+                       t.Errorf("%d: got = %v; want %v", i, got, tt.want)
                }
        }
 }