]> Cypherpunks repositories - gostls13.git/commitdiff
net/http: skip TestServerHijackGetsBackgroundByte on Plan 9
authorDavid du Colombier <0intro@gmail.com>
Sat, 14 Jan 2017 13:13:58 +0000 (14:13 +0100)
committerBrad Fitzpatrick <bradfitz@golang.org>
Sat, 14 Jan 2017 17:11:31 +0000 (17:11 +0000)
CL 5232 added TestServerHijackGetsBackgroundByte, which is failing
on Plan 9, because CloseWrite is not implemented on Plan 9 yet.

Updates #17906.
Updates #18657.

Change-Id: I3c2f73760b0f767f3f9ed2698c855372170e0481
Reviewed-on: https://go-review.googlesource.com/35178
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
src/net/http/serve_test.go

index bc76407b38e803474a73d834745f0fb71c14e6a9..681dff193aa1dd6ef5d0f31c88ed3c9d0ceb85c7 100644 (file)
@@ -5180,6 +5180,9 @@ func TestServerDuplicateBackgroundRead(t *testing.T) {
 // bufio.Reader.Buffered(), without resorting to Reading it
 // (potentially blocking) to get at it.
 func TestServerHijackGetsBackgroundByte(t *testing.T) {
+       if runtime.GOOS == "plan9" {
+               t.Skip("skipping test; see https://golang.org/issue/18657")
+       }
        setParallel(t)
        defer afterTest(t)
        done := make(chan struct{})